Page MenuHomePhabricator

Add a "commits" attachment to "differential.diff.search" for retrieving local commit information
ClosedPublic

Authored by epriestley on Apr 19 2018, 7:02 PM.
Tags
None
Referenced Files
F15419663: D19386.id46369.diff
Fri, Mar 21, 7:50 AM
F15402739: D19386.id.diff
Tue, Mar 18, 12:04 AM
F15397472: D19386.diff
Sun, Mar 16, 8:25 PM
F15336793: D19386.id46369.diff
Sun, Mar 9, 1:37 AM
F15333459: D19386.id.diff
Sat, Mar 8, 2:26 AM
F15333358: D19386.id46376.diff
Sat, Mar 8, 2:03 AM
F15331844: D19386.diff
Fri, Mar 7, 2:27 PM
F15331767: D19386.id46369.diff
Fri, Mar 7, 1:30 PM
Subscribers
None

Details

Summary

Ref T13124. See PHI593.

When you arc diff in a Git or Mercurial repository, we upload some information about the local commits in your working copy which the change was generated from.

In the future (for example, with T1508) we may increase the prominence of this feature.

Provide a stable way to read this information back via the API. This roughly mirrors the information we provide about commits in "diffusion.commit.search", although the latter is less fleshed-out today.

Test Plan

Used differential.diff.search to retrieve commit information about Git, Mercurial, and Subversion diffs. (There's no info for Subversion, but it doesn't crash or anything.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable