Page MenuHomePhabricator

When creating a file by downloading a URI, truncate the length of the default name
ClosedPublic

Authored by epriestley on Apr 12 2018, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 2:20 AM
Unknown Object (File)
Mon, Apr 15, 9:17 PM
Unknown Object (File)
Sun, Apr 7, 5:34 PM
Unknown Object (File)
Sat, Mar 30, 4:24 PM
Unknown Object (File)
Mar 5 2024, 5:20 PM
Unknown Object (File)
Jan 24 2024, 3:39 PM
Unknown Object (File)
Dec 25 2023, 10:40 PM
Unknown Object (File)
Nov 30 2023, 8:37 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/embedding-external-images-url-show-error-for-long-urls/1339.

When we download a file from a URI, we provide a default name based on the URI. However, if the URI is something like http://example.com/very-very-very-....-long.jpg with more than 255 characters, we may suggest a name which won't fit into the name column of PhabricatorFile.

Instead, suggest a default name no longer than 64 bytes.

Test Plan
  • Used the {image ...} example from the Discourse report locally; got an image with a truncated name.
  • Used a normal {image ...}, got an image file with a normal name.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable