Page MenuHomePhabricator
Differential D19309

Mostly make blame work with DocumentEngine
ClosedPublic
Actions

Authored by epriestley on Apr 8 2018, 7:53 PM.
Tags
None
Referenced Files
F18695082: D19309.id.diff
Sat, Sep 27, 5:02 AM
F18673068: D19309.diff
Thu, Sep 25, 9:15 AM
F18667027: D19309.id46200.diff
Wed, Sep 24, 8:50 AM
F18653011: D19309.diff
Sun, Sep 21, 10:33 AM
F18637268: D19309.id46207.diff
Wed, Sep 17, 6:50 AM
F18588053: D19309.id46207.diff
Sep 11 2025, 11:10 PM
F18587572: D19309.id46207.diff
Sep 11 2025, 9:49 PM
F18553181: D19309.id46207.diff
Sep 8 2025, 2:38 PM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP09c6d42b9599: Mostly make blame work with DocumentEngine
Summary

Ref T13105. This needs refinement but blame sort of works again, now.

Test Plan

Viewed files in Diffusion and Files; saw blame in Diffusion when viewing in source mode.

Diff Detail

Repository
rP Phabricator
Branch
dfile7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20024
Build 27155: Run Core Tests
Build 27154: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 8 2018, 7:53 PM
Harbormaster completed remote builds in B20024: Diff 46200.Apr 8 2018, 7:54 PM
epriestley requested review of this revision.Apr 8 2018, 7:54 PM
mydeveloperday accepted this revision.Apr 9 2018, 10:13 AM
This revision is now accepted and ready to land.Apr 9 2018, 10:13 AM
Closed by commit rP09c6d42b9599: Mostly make blame work with DocumentEngine (authored by epriestley). · Explain WhyApr 9 2018, 11:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
1 line
src/
2 lines
applications/
diffusion/
application/
2 lines
controller/
254 lines
264 lines
document/
12 lines
files/
document/
4 lines
8 lines
14 lines
21 lines
render/
20 lines
repository/
storage/
2 lines
22 lines
view/
layout/
44 lines
webroot/
rsrc/
css/
application/
differential/
4 lines
diffusion/
layout/
43 lines
js/
application/
diffusion/
files/
84 lines

Diff 46200

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBlameController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/document/DiffusionDocumentRenderingEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorDocumentRef.php

Loading...
View Options

src/applications/files/document/PhabricatorSourceDocumentEngine.php

Loading...
View Options

src/applications/files/document/PhabricatorTextDocumentEngine.php

Loading...
View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/view/layout/PhabricatorSourceCodeView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-source.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...
View Options

webroot/rsrc/js/application/diffusion/behavior-load-blame.js

Loading...
View Options

webroot/rsrc/js/application/files/behavior-document-engine.js

Loading...
Phabricator · Built by Phacility