Page MenuHomePhabricator

Pull file Document Engine rendering out of "Files" application controllers
ClosedPublic

Authored by epriestley on Apr 5 2018, 4:17 PM.

Details

Summary

Ref T13105. This separates document rendering from the Controllers which trigger it so it can be reused elsewhere (notably, in Diffusion).

This shouldn't cause any application behavior to change, it just pulls the rendering logic out so it can be reused elsewhere.

Test Plan

Viewed various types of files in Files; toggled rendering, highlighting, and encoding.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Apr 5 2018, 4:17 PM
epriestley requested review of this revision.Apr 5 2018, 4:18 PM
mydeveloperday accepted this revision.Apr 5 2018, 5:05 PM
This revision is now accepted and ready to land.Apr 5 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.