Page MenuHomePhabricator
Differential D19300

Remove the ability to disable blame in Diffusion
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 2:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:30 AM
Unknown Object (File)
Fri, Apr 19, 7:38 PM
Unknown Object (File)
Wed, Apr 17, 4:14 PM
Unknown Object (File)
Mon, Apr 15, 12:04 AM
Unknown Object (File)
Sun, Apr 14, 9:14 AM
Unknown Object (File)
Fri, Apr 12, 12:03 AM
Unknown Object (File)
Thu, Apr 11, 10:43 PM
Unknown Object (File)
Thu, Apr 11, 9:58 AM
View All Files
Subscribers
None

Details

Reviewers
mydeveloperday
Maniphest Tasks
T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits
rP7d4e25614d00: Remove the ability to disable blame in Diffusion
Summary

Ref T13105. Given that we now load blame with AJAX, it's not clear that there's any benefit to disabling it. This would also interact oddly with the document engine.

Test Plan

Viewed files in Diffusion, no longer saw blame-related options.

Diff Detail

Repository
rP Phabricator
Branch
dfile1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20010
Build 27132: Run Core Tests
Build 27131: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
126 lines

Diff 46188

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility