Differential D19300

Remove the ability to disable blame in Diffusion
ClosedPublic
Actions

Authored by epriestley on Apr 5 2018, 2:33 PM.

Tags

None

Referenced Files

	F14754721: D19300.id46201.diff
	Tue, Jan 21, 3:38 PM

	F14753893: D19300.id46188.diff
	Tue, Jan 21, 3:21 PM

	F14750451: D19300.id.diff
	Tue, Jan 21, 11:51 AM

	Unknown Object (File)
	Sat, Jan 18, 2:29 AM

	Unknown Object (File)
	Fri, Jan 3, 2:30 AM

	Unknown Object (File)
	Nov 28 2024, 11:40 AM

	Unknown Object (File)
	Nov 22 2024, 4:01 AM

	Unknown Object (File)
	Nov 18 2024, 6:26 PM

View All Files

Subscribers

None

Details

Reviewers

mydeveloperday

Maniphest Tasks

T13105: Plans: Rich presentation and diff rendering pipelines for various file types

Commits

rP7d4e25614d00: Remove the ability to disable blame in Diffusion

Summary

Ref T13105. Given that we now load blame with AJAX, it's not clear that there's any benefit to disabling it. This would also interact oddly with the document engine.

Test Plan

Viewed files in Diffusion, no longer saw blame-related options.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 5 2018, 2:33 PM

Harbormaster completed remote builds in B20010: Diff 46188.Apr 5 2018, 2:34 PM

epriestley requested review of this revision.Apr 5 2018, 2:34 PM

mydeveloperday accepted this revision.Apr 5 2018, 5:06 PM

This revision is now accepted and ready to land.Apr 5 2018, 5:06 PM

Closed by commit rP7d4e25614d00: Remove the ability to disable blame in Diffusion (authored by epriestley). · Explain WhyApr 9 2018, 11:45 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

126 lines

Diff 46201

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Remove the ability to disable blame in DiffusionClosedPublicActions