Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F15447306: D19272.diff
Thu, Mar 27, 11:02 PM
F15431670: D19272.id.diff
Mon, Mar 24, 1:51 PM
F15425716: D19272.id46133.diff
Sun, Mar 23, 5:39 AM
F15424831: D19272.diff
Sun, Mar 23, 12:24 AM
F15417346: D19272.diff
Thu, Mar 20, 4:42 PM
F15415851: D19272.id46131.diff
Thu, Mar 20, 7:59 AM
F15377279: D19272.diff
Thu, Mar 13, 8:31 AM
Unknown Object (File)
Feb 26 2025, 2:17 PM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.