Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F15577119: D19272.diff
Tue, May 6, 12:25 PM
F15574523: D19272.diff
Tue, May 6, 1:56 AM
F15540977: D19272.id46133.diff
Fri, Apr 25, 10:00 AM
F15535761: D19272.diff
Thu, Apr 24, 6:36 AM
F15530579: D19272.id46131.diff
Wed, Apr 23, 6:02 AM
F15525958: D19272.id46133.diff
Mon, Apr 21, 6:04 PM
F15522071: D19272.id46131.diff
Sun, Apr 20, 6:00 PM
F15515519: D19272.id.diff
Fri, Apr 18, 11:17 AM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.