Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F19280290: D19272.diff
Tue, Dec 23, 3:07 AM
F19095261: D19272.diff
Dec 4 2025, 4:35 AM
F18824757: D19272.id46133.diff
Oct 23 2025, 5:45 PM
F18812076: D19272.diff
Oct 20 2025, 6:45 AM
F18808606: D19272.id.diff
Oct 19 2025, 7:26 AM
F18773791: D19272.id46131.diff
Oct 9 2025, 12:41 PM
F18770787: D19272.diff
Oct 8 2025, 2:54 PM
F18741252: D19272.id.diff
Oct 2 2025, 9:32 AM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.