Page MenuHomePhabricator

Make closed/disabled results in the remarkup autocomplete more visually clear
ClosedPublic

Authored by epriestley on Mar 30 2018, 3:45 PM.
Tags
None
Referenced Files
F18435414: D19272.id.diff
Sun, Aug 31, 10:04 AM
F18409909: D19272.diff
Sat, Aug 30, 4:26 AM
F18095029: D19272.diff
Thu, Aug 7, 10:29 PM
F17953595: D19272.id46133.diff
Aug 1 2025, 3:13 AM
F17948776: D19272.id46131.diff
Jul 31 2025, 10:00 PM
F17939783: D19272.diff
Jul 31 2025, 3:26 AM
F17759309: D19272.diff
Jul 22 2025, 6:20 PM
F17699333: D19272.id46133.diff
Jul 15 2025, 7:55 PM
Subscribers
None

Details

Summary

Ref T13114. See PHI522. Although it looks like results are already ordered correctly, the override rendering isn't accommodating disabled results gracefully.

Give closed results a distinctive look (grey + strikethru) so it's clear when you're autocompleting @mention... into a disabled user.

Test Plan

Screen Shot 2018-03-30 at 8.41.49 AM.png (221×362 px, 23 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2018, 3:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.