Details
Details
- Reviewers
- None
- Maniphest Tasks
- T13114: Plans: 2018 Week 13 Bonus Content
- Commits
- rPb586ee065a75: Stop evaluating Herald rules when writing "someone mentioned this somewhere…
Mentioned tasks on other tasks; verified that the normal path is hit normally, the new Herald-free path is hit on the mentioned object, and both still work fine and show up in the timeline.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- inv1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 19935 Build 27023: Run Core Tests Build 27022: arc lint + arc unit
Event Timeline
Comment Actions
Although I'm focusing on "mentions" here, "inverse edge edits" apply more broadly to any situation where an object is the far end of a link, so Ref Xyz., Fixes Xyz., Depends on Dxxx., "Edit Parent Tasks", etc. will also hit this logic. I think this is appropriate in all cases -- it doesn't feel to me like any of these "another object is now related to this object somehow" changes should be firing Herald updates on the target.