Details
- Reviewers
- None
- Commits
- rARCb8c9c385a7f5: Survive extra "obsolete:" log output from the Mercurial evolve extension
I spent all of three minutes trying to install the evolve extension without success and gave up, but this probably does the right thing based on the example output in the Bugzilla issue.
Diff Detail
- Repository
- rARC Arcanist
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1448137#c5, I think the parser should be modified to not barf on unexpected input lines. Otherwise this will continue to break when Mercurial adds new labels to hg log output. Using HGPLAIN does offer you some protection here. But it is no guarantee against future additions.
I think that's generally okay -- time between the report reaching the upstream and a patch being available was about 90 minutes, and new versions of hg don't appear everywhere in the wild at once.
If there's an extra line because, e.g., the working copy is an old working copy with a branch that contains a newline (which I think was possible in era of T5304#62959) it's probably good that we break explicitly rather than continue with mangled information.
If you ever feel like trying to setup evolve again the instructions we use:
- Clone the evolve repository https://www.mercurial-scm.org/repo/evolve/ (assume running clone in ~/Projects/)
- Update .hg/hgrc or ~/.hgrc to contain
[extensions] evolve=~/Projects/evolve/hgext3rd/evolve
Ah, thanks! The instructions I hit first were based on pip, which I don't have set up, but the clone + configure approach is better for me anyway.