Page MenuHomePhabricator

Improve minor client behaviors for document rendering
ClosedPublic

Authored by epriestley on Mar 23 2018, 8:49 PM.

Details

Summary

Ref T13105. This adds various small client-side improvements to document rendering.

  • In the menu, show which renderer is in use.
  • Make linking to lines work.
  • Make URIs persist information about which rendering engine is in use.
  • Improve the UI feedback for transitions between document types.
  • Load slower documents asynchronously by default.
  • Discard irrelevant requests if you spam the view menu.
Test Plan

Loaded files, linked to lines, swapped between modes, copy/pasted URLs.

Diff Detail

Repository
rP Phabricator
Branch
docu6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19918
Build 26999: Run Core Tests
Build 26998: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2018, 9:09 PM
This revision was automatically updated to reflect the committed changes.