Page MenuHomePhabricator

Add a PDF document "rendering" engine
ClosedPublic

Authored by epriestley on Mar 23 2018, 12:10 PM.

Details

Summary

Depends on D19251. Ref T13105. This adds rendering engine support for PDFs.

It doesn't actually render them, it just renders a link which you can click to view them in a new window. This is much easier than actually rendering them inline and at least 95% as good most of the time (and probably more-than-100%-as-good some of the time).

This makes PDF a viewable MIME type by default and adds a narrow CSP exception for it. See also T13112.

Test Plan
  • Viewed PDFs in Files, got a link to view them in a new tab.
  • Clicked the link in Safari, Chrome, and Firefox; got inline PDFs.
  • Verified primary CSP is still object-src 'none' with curl ....
  • Interacted with the vanilla lightbox element to check that it still works.

Diff Detail

Repository
rP Phabricator
Branch
docu2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19909
Build 26986: Run Core Tests
Build 26985: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2018, 2:14 PM
This revision was automatically updated to reflect the committed changes.