Page MenuHomePhabricator

Improve help and prompts for the "--draft" flag
ClosedPublic

Authored by epriestley on Mar 15 2018, 3:22 AM.
Tags
None
Referenced Files
F13147872: D19229.diff
Fri, May 3, 6:14 PM
F13140781: D19229.diff
Fri, May 3, 3:57 AM
Unknown Object (File)
Mon, Apr 29, 4:06 PM
Unknown Object (File)
Wed, Apr 24, 11:54 PM
Unknown Object (File)
Thu, Apr 18, 4:08 AM
Unknown Object (File)
Sun, Apr 14, 10:40 PM
Unknown Object (File)
Sun, Apr 14, 10:32 AM
Unknown Object (File)
Thu, Apr 11, 9:53 PM
Subscribers
None

Details

Summary

See PHI458. The help text and prompting for "arc diff --draft" aren't very clear about whether updating publishes or not, nor about whether you need to keep passing "--draft" every time.

Make these behaviors more clear.

Test Plan
  • Ran arc help diff, read text.
  • Updated a draft with "--draft", got new warning but it went through.
  • Updated a published revision with "--draft", got new error.

Diff Detail

Repository
rARC Arcanist
Branch
draft1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistDiffWorkflow.php:1812XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19858
Build 26911: Run Core Tests
Build 26910: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 15 2018, 3:23 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.