Page MenuHomePhabricator

Add a UI element for reviewing older generations of Harbormaster builds
ClosedPublic

Authored by epriestley on Mar 13 2018, 11:12 PM.
Tags
None
Referenced Files
F14113694: D19217.diff
Thu, Nov 28, 6:02 AM
Unknown Object (File)
Wed, Nov 27, 5:42 AM
Unknown Object (File)
Sun, Nov 24, 2:22 AM
Unknown Object (File)
Fri, Nov 22, 4:32 PM
Unknown Object (File)
Tue, Nov 19, 10:40 AM
Unknown Object (File)
Fri, Nov 15, 2:56 PM
Unknown Object (File)
Mon, Nov 11, 1:39 PM
Unknown Object (File)
Sun, Nov 10, 11:23 PM
Subscribers
Restricted Owners Package

Details

Summary

See PHI446. Ref T13088. Currently, there's no way to access older generations of a build unless you know the secret ?g=1 URI magic.

When a build has multiple generations, show a history table and let users click to see older run information.

This is currently very basic. It would be nice to show when each generation started, who started/restarted it, and what the build status was at the time the build was restarted. There's currently no convenient source for this information so just add a bare-bones, working version of this for now.

Test Plan

Viewed pending, single-run and multi-restart builds. Saw table on builds with more than one generation. Clicked table entries to see different build data.

Screen Shot 2018-03-13 at 4.07.10 PM.png (1×1 px, 174 KB)

Diff Detail

Repository
rP Phabricator
Branch
harbor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19835
Build 26876: Run Core Tests
Build 26875: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 13 2018, 11:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 11:13 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.