Differential D19205

Fix missing parameter in parent call for Differential button text
ClosedPublic
Actions

Authored by epriestley on Mar 9 2018, 1:20 PM.

Tags

None

Referenced Files

	F18829392: D19205.id.diff
	Fri, Oct 24, 9:40 PM

	F18824005: D19205.diff
	Thu, Oct 23, 2:03 PM

	F18796975: D19205.id45992.diff
	Fri, Oct 17, 4:30 AM

	F18786341: D19205.id.diff
	Tue, Oct 14, 6:37 PM

	F18762512: D19205.diff
	Mon, Oct 6, 7:23 PM

	F18733764: D19205.diff
	Tue, Sep 30, 10:41 PM

	F18634144: D19205.id.diff
	Sep 16 2025, 9:42 PM

	F18622912: D19205.diff
	Sep 15 2025, 1:30 PM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP1763b516b158: Fix missing parameter in parent call for Differential button text

Summary

See https://discourse.phabricator-community.org/t/openning-any-differential-fails-with-undefined-variable-object/1216/1.

Test Plan

Loaded any non-draft revision.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 9 2018, 1:20 PM

Harbormaster completed remote builds in B19808: Diff 45992.Mar 9 2018, 1:21 PM

epriestley requested review of this revision.Mar 9 2018, 1:21 PM

epriestley mentioned this in D19204: Add some more UI reminder text about draft revisions.Mar 9 2018, 1:22 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 9 2018, 1:23 PM

Closed by commit rP1763b516b158: Fix missing parameter in parent call for Differential button text (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

2 lines

Diff 45993

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Fix missing parameter in parent call for Differential button textClosedPublicActions