Page MenuHomePhabricator

Stop sending Phriction edit mail to the previous/current content author
ClosedPublic

Authored by epriestley on Feb 27 2018, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 12 2026, 9:09 PM
Unknown Object (File)
Dec 22 2025, 6:40 PM
Unknown Object (File)
Oct 31 2025, 7:51 AM
Unknown Object (File)
Oct 22 2025, 6:38 PM
Unknown Object (File)
Oct 22 2025, 6:46 AM
Unknown Object (File)
Oct 9 2025, 10:45 AM
Unknown Object (File)
Sep 30 2025, 5:49 AM
Unknown Object (File)
Sep 24 2025, 2:12 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/previous-author-of-phriction-page-always-receives-mail-when-new-author-edits-the-page/1155.

After the "send users email when they are removed from the reviewer list" change which includes old To/Cc on the list, Phriction now emails the previous editor.

This is weird and unintended. The behavior isn't necessarily always bad, but if it's sometimes desirable we should make it explicit.

For now, just get rid of the weird side effect.

Test Plan

Edited a Phriction page.

Diff Detail

Repository
rP Phabricator
Branch
phriction1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19682
Build 26653: Run Core Tests
Build 26652: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 11:05 PM
This revision was automatically updated to reflect the committed changes.