Page MenuHomePhabricator

Stop sending Phriction edit mail to the previous/current content author
ClosedPublic

Authored by epriestley on Feb 27 2018, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 14, 7:00 PM
Unknown Object (File)
Fri, Jan 31, 9:02 AM
Unknown Object (File)
Mon, Jan 27, 6:33 PM
Unknown Object (File)
Sat, Jan 25, 5:20 AM
Unknown Object (File)
Thu, Jan 23, 2:31 AM
Unknown Object (File)
Tue, Jan 21, 10:37 AM
Unknown Object (File)
Jan 18 2025, 12:25 AM
Unknown Object (File)
Jan 6 2025, 3:28 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/previous-author-of-phriction-page-always-receives-mail-when-new-author-edits-the-page/1155.

After the "send users email when they are removed from the reviewer list" change which includes old To/Cc on the list, Phriction now emails the previous editor.

This is weird and unintended. The behavior isn't necessarily always bad, but if it's sometimes desirable we should make it explicit.

For now, just get rid of the weird side effect.

Test Plan

Edited a Phriction page.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 11:05 PM
This revision was automatically updated to reflect the committed changes.