Page MenuHomePhabricator

Make the filetree view width sticky across show/hide and reload
ClosedPublic

Authored by epriestley on Feb 22 2018, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 6:44 AM
Unknown Object (File)
Thu, Jan 2, 2:55 AM
Unknown Object (File)
Thu, Dec 19, 8:12 PM
Unknown Object (File)
Thu, Dec 12, 1:02 AM
Unknown Object (File)
Dec 9 2024, 12:06 PM
Unknown Object (File)
Dec 6 2024, 5:59 AM
Unknown Object (File)
Dec 4 2024, 3:48 AM
Unknown Object (File)
Dec 3 2024, 11:57 PM
Subscribers
None

Details

Summary

Ref T13090. The default width changed recently to become much wider, but the behavior on this control isn't great. Instead:

  • Pick a default width somewhere between the two.
  • Make the width sticky across show/hide (pressing "f" twice remembers your width instead of resetting it).
  • Make the width sticky across reloads (dragging the bar, then reloading the page keeps the bar in the same place).
Test Plan
  • Without settings, loaded page: got medium-width bar.
  • Dragged bar wide/narrow, toggled on/off with "f", got persistent width.
  • Dragged bar wide/narrow, reloaded page, got persistent width.
  • Dragged bar wide/narrow, toggled it off, reloaded page, toggled it on, got persistent width.

Diff Detail

Repository
rP Phabricator
Branch
treedrag1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19643
Build 26595: Run Core Tests
Build 26594: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.