Page MenuHomePhabricator

Make the filetree view width sticky across show/hide and reload
ClosedPublic

Authored by epriestley on Feb 22 2018, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 8:12 PM
Unknown Object (File)
Thu, Dec 12, 1:02 AM
Unknown Object (File)
Mon, Dec 9, 12:06 PM
Unknown Object (File)
Fri, Dec 6, 5:59 AM
Unknown Object (File)
Wed, Dec 4, 3:48 AM
Unknown Object (File)
Tue, Dec 3, 11:57 PM
Unknown Object (File)
Nov 19 2024, 7:53 AM
Unknown Object (File)
Nov 15 2024, 8:56 AM
Subscribers
None

Details

Summary

Ref T13090. The default width changed recently to become much wider, but the behavior on this control isn't great. Instead:

  • Pick a default width somewhere between the two.
  • Make the width sticky across show/hide (pressing "f" twice remembers your width instead of resetting it).
  • Make the width sticky across reloads (dragging the bar, then reloading the page keeps the bar in the same place).
Test Plan
  • Without settings, loaded page: got medium-width bar.
  • Dragged bar wide/narrow, toggled on/off with "f", got persistent width.
  • Dragged bar wide/narrow, reloaded page, got persistent width.
  • Dragged bar wide/narrow, toggled it off, reloaded page, toggled it on, got persistent width.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.