Page MenuHomePhabricator
Differential D19101

Render Drydock logs in text from "bin/drydock lease"; in HTML in web views
ClosedPublic
Actions

Authored by epriestley on Feb 15 2018, 11:39 PM.
Tags
None
Referenced Files
F15534425: D19101.diff
Thu, Apr 24, 12:22 AM
F15524390: D19101.id45767.diff
Mon, Apr 21, 7:43 AM
F15513974: D19101.id45767.diff
Thu, Apr 17, 11:27 PM
F15496353: D19101.id45767.diff
Sun, Apr 13, 6:32 AM
F15478814: D19101.id45771.diff
Tue, Apr 8, 3:00 AM
F15473353: D19101.diff
Sat, Apr 5, 9:05 PM
F15460059: D19101.id.diff
Mon, Mar 31, 7:45 PM
F15450816: D19101.id45771.diff
Fri, Mar 28, 6:23 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds
Commits
rP463dda98edd3: Render Drydock logs in text from "bin/drydock lease"; in HTML in web views
Summary

Ref T13073. The new log output from bin/drydock lease currently uses HTML handle rendering, but should render to text.

Test Plan

Ran bin/drydock lease and saw normal text in log output. Viewed the same logs from the web UI and saw HTML.

Diff Detail

Repository
rP Phabricator
Branch
ddlog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19571
Build 26493: Run Core Tests
Build 26492: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2018, 11:39 PM
Owners added a subscriber: Restricted Owners Package.Feb 15 2018, 11:39 PM
Harbormaster completed remote builds in B19571: Diff 45767.Feb 15 2018, 11:40 PM
epriestley requested review of this revision.Feb 15 2018, 11:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 1:25 AM
Closed by commit rP463dda98edd3: Render Drydock logs in text from "bin/drydock lease"; in HTML in web views (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45767

View Options

src/applications/drydock/logtype/DrydockLeaseNoAuthorizationsLogType.php

Loading...
View Options

src/applications/drydock/logtype/DrydockLeaseReclaimLogType.php

Loading...
View Options

src/applications/drydock/logtype/DrydockLeaseWaitingForResourcesLogType.php

Loading...
View Options

src/applications/drydock/logtype/DrydockLogType.php

Loading...
View Options

src/applications/drydock/logtype/DrydockResourceReclaimLogType.php

Loading...
View Options

src/applications/drydock/management/DrydockManagementLeaseWorkflow.php

Loading...
View Options

src/applications/drydock/view/DrydockLogListView.php

Loading...
Phabricator · Built by Phacility