When a ChangesetList sleeps after a Quicksand navigation, also hide any visible banner
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 11:22 PM.

Details

Reviewers: None
Maniphest Tasks: T13080: Freeze header from differential sometimes sticks around when using the back button
Commits: rPa4053bb5808e: When a ChangesetList sleeps after a Quicksand navigation, also hide any visible…

Summary

Fixes T13080. The banner wasn't properly included in the sleep/wake logic.

Test Plan

Mentioned Dxxx on a task. Enabled persistent chat to activate Quicksand. Reloaded page. Clicked Dxxx. Scrolled down until a changeset header appeared. Pressed back button.

Before patch: ended up on task, with header still around.
After patch: ended up on task, with header properly vanquished.

Pressed "forward", ended up back on the revision with the header again.

Diff Detail

Repository

rP Phabricator

Branch

header1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19550
Build 26457: Run Core Tests
Build 26456: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 14 2018, 11:22 PM

Harbormaster completed remote builds in B19550: Diff 45746.Feb 14 2018, 11:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2018, 11:23 PM

epriestley requested review of this revision.

Closed by commit rPa4053bb5808e: When a ChangesetList sleeps after a Quicksand navigation, also hide any visible… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

14 lines

webroot/

rsrc/

js/

application/

diff/

DiffChangesetList.js

16 lines

Diff 45746

View Options

resources/celerity/map.php