Fix a mail stamp issue with blocking reviewers
ClosedPublic
Actions

Authored by epriestley on Feb 14 2018, 1:54 AM.

Details

Reviewers: None
Commits: rP708acce9275a: (stable) Fix a mail stamp issue with blocking reviewers
rP743f0d65eaec: Fix a mail stamp issue with blocking reviewers

Summary

Revisions with blocking reviewers had this stamp built incorrectly, which cascaded into trying to use array() as a PHID. Recover so these tasks succeed.

Test Plan

Will deploy production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2018, 1:54 AM

Harbormaster completed remote builds in B19540: Diff 45738.Feb 14 2018, 1:55 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 14 2018, 1:55 AM

epriestley requested review of this revision.

Closed by commit rP743f0d65eaec: Fix a mail stamp issue with blocking reviewers (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D19079: Cut the middle, not bottom, of a big traceback.Feb 14 2018, 1:59 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

engineextension/

DifferentialMailEngineExtension.php

2 lines

metamta/

stamp/

PhabricatorPHIDMailStamp.php

9 lines

Diff 45739

View Options

src/applications/differential/engineextension/DifferentialMailEngineExtension.php