Differential D19069

Don't allow Herald Diff rules to "Call Webhooks"
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 11:36 PM.

Tags

None

Referenced Files

	F14844632: D19069.diff
	Sun, Feb 2, 5:17 PM

	Unknown Object (File)
	Wed, Jan 29, 9:28 AM

	Unknown Object (File)
	Fri, Jan 17, 2:57 PM

	Unknown Object (File)
	Thu, Jan 9, 2:50 PM

	Unknown Object (File)
	Dec 12 2024, 11:05 AM

	Unknown Object (File)
	Dec 7 2024, 7:36 AM

	Unknown Object (File)
	Dec 6 2024, 11:53 PM

	Unknown Object (File)
	Dec 6 2024, 4:46 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP6a4d5ce3c93e: Don't allow Herald Diff rules to "Call Webhooks"

Summary

Like "Commit Hook" rules, these also fire oddly and don't have an object PHID or a list of transactions.

Test Plan

Verified that "Call Webhooks" was no longer available from Diff rules, but still available from other rule types.

Diff Detail

Repository

rP Phabricator

Branch

hook9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19515
Build 26405: Run Core Tests
Build 26404: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2018, 11:36 PM

Harbormaster completed remote builds in B19515: Diff 45712.Feb 12 2018, 11:37 PM

epriestley requested review of this revision.Feb 12 2018, 11:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2018, 1:52 AM

Closed by commit rP6a4d5ce3c93e: Don't allow Herald Diff rules to "Call Webhooks" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

herald/

HeraldDifferentialDiffAdapter.php

4 lines

Diff 45712

View Options

src/applications/differential/herald/HeraldDifferentialDiffAdapter.php

Don't allow Herald Diff rules to "Call Webhooks"ClosedPublicActions