Page MenuHomePhabricator
Differential D19068

Update a handful of missed HarbormasterBuildableStatus constants
ClosedPublic
Actions

Authored by epriestley on Feb 12 2018, 11:32 PM.
Tags
None
Referenced Files
F13099112: D19068.diff
Fri, Apr 26, 1:13 PM
F13096712: D19068.diff
Thu, Apr 25, 6:29 PM
Unknown Object (File)
Wed, Apr 24, 8:44 AM
Unknown Object (File)
Fri, Apr 19, 7:52 PM
Unknown Object (File)
Wed, Apr 17, 3:13 PM
Unknown Object (File)
Thu, Apr 11, 7:22 AM
Unknown Object (File)
Tue, Apr 9, 6:12 PM
Unknown Object (File)
Sat, Mar 30, 6:47 PM
View All Files
Subscribers
mydeveloperday

Details

Reviewers
None
Commits
rP894e9dd852fa: Update a handful of missed HarbormasterBuildableStatus constants
Summary

See https://discourse.phabricator-community.org/t/exception-undefined-class-status-building/1103.

Test Plan

Used grep more carefully.

Diff Detail

Repository
rP Phabricator
Branch
build7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19513
Build 26402: Run Core Tests
Build 26401: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 12 2018, 11:32 PM
Harbormaster completed remote builds in B19513: Diff 45710.Feb 12 2018, 11:32 PM
Harbormaster completed remote builds in B19513: Diff 45710.
This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 11:33 PM
epriestley requested review of this revision.
Closed by commit rP894e9dd852fa: Update a handful of missed HarbormasterBuildableStatus constants (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
mydeveloperday added a subscriber: mydeveloperday.Feb 12 2018, 11:35 PM

thank you for the speedy response, looks good to me ;-)

Revision Contents
Changeset List

PathSize
src/
applications/
transactions/
storage/
10 lines

Diff 45710

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility