Page MenuHomePhabricator

Allow "arc diff --plan-changes" to work with drafts enabled
ClosedPublic

Authored by epriestley on Feb 12 2018, 9:04 PM.
Tags
None
Referenced Files
F19826352: D19067.diff
Sun, Mar 8, 7:36 PM
F19825387: D19067.diff
Sun, Mar 8, 10:59 AM
F19693175: D19067.diff
Tue, Feb 10, 8:14 AM
F19369003: D19067.diff
Dec 26 2025, 2:50 PM
F19007086: D19067.diff
Nov 21 2025, 7:15 PM
F19006934: D19067.diff
Nov 21 2025, 7:07 PM
F18856356: D19067.id.diff
Nov 1 2025, 9:22 AM
F18853153: D19067.diff
Oct 31 2025, 2:34 PM
Subscribers
None

Details

Summary

See PHI346. Ref T13054. If you have prototypes enabled on the server but use master / stable on the client and run arc diff --plan-changes, the transition is rejected because "Draft -> Changes Planned" isn't currently a legal transition.

Allow this transition if not coming from the web UI (to keep it out of the dropdown).

Test Plan
  • Ran arc diff --plan-changes on master, got a "Changes Planned" revision instead of a validation error.
  • Ran arc diff without --plan-changes, got a draft, verified that "Plan Changes" still doesn't appear in the action dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 12 2018, 9:15 PM
This revision was automatically updated to reflect the committed changes.