Page MenuHomePhabricator

Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it
ClosedPublic

Authored by epriestley on Feb 11 2018, 1:59 PM.
Tags
None
Referenced Files
F13300817: D19061.diff
Fri, Jun 7, 10:17 AM
F13281823: D19061.diff
Sun, Jun 2, 11:16 AM
F13267503: D19061.diff
Wed, May 29, 3:31 AM
F13262696: D19061.id45695.diff
Mon, May 27, 2:30 AM
F13252950: D19061.diff
Sat, May 25, 2:14 AM
F13249173: D19061.diff
Fri, May 24, 7:20 AM
F13231226: D19061.diff
Tue, May 21, 12:17 AM
F13185364: D19061.diff
Sat, May 11, 2:50 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/herald-webhook-is-not-called-but-herald-transcript-tells-me-the-opposite/1098.

The "Commit Hook" events don't operate on objects and don't use TransactionEditors. They can't call webhooks in a normal way and currently don't call webhooks at all. Stop offering these actions in the UI.

The "Outbound Mail" event also fires oddly and likely doesn't make much sense to hook anyway.

Test Plan

Verified that these events no longer offer "Call webhooks", while normal events still do.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.