Page MenuHomePhabricator

Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it
ClosedPublic

Authored by epriestley on Feb 11 2018, 1:59 PM.
Tags
None
Referenced Files
F13185364: D19061.diff
Sat, May 11, 2:50 AM
Unknown Object (File)
Tue, May 7, 5:16 AM
Unknown Object (File)
Mon, May 6, 1:33 PM
Unknown Object (File)
Fri, May 3, 2:37 AM
Unknown Object (File)
Mon, Apr 29, 2:10 PM
Unknown Object (File)
Wed, Apr 24, 10:14 PM
Unknown Object (File)
Apr 11 2024, 7:32 AM
Unknown Object (File)
Mar 30 2024, 6:45 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/herald-webhook-is-not-called-but-herald-transcript-tells-me-the-opposite/1098.

The "Commit Hook" events don't operate on objects and don't use TransactionEditors. They can't call webhooks in a normal way and currently don't call webhooks at all. Stop offering these actions in the UI.

The "Outbound Mail" event also fires oddly and likely doesn't make much sense to hook anyway.

Test Plan

Verified that these events no longer offer "Call webhooks", while normal events still do.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.