Page MenuHomePhabricator
Differential D19059

Read lock all transaction edits
ClosedPublic
Actions

Authored by epriestley on Feb 11 2018, 2:05 AM.
Tags
None
Referenced Files
F19947651: D19059.diff
Fri, Apr 17, 8:20 AM
F19922828: D19059.id45693.diff
Mon, Apr 6, 10:04 PM
F19898509: D19059.id.diff
Sun, Mar 29, 1:16 PM
F19894631: D19059.diff
Sat, Mar 28, 4:06 PM
F19866055: D19059.id45693.diff
Mar 14 2026, 4:40 PM
F19757175: D19059.id45692.diff
Feb 17 2026, 7:37 PM
F19745202: D19059.id45692.diff
Feb 15 2026, 3:15 PM
F19565133: D19059.id45692.diff
Jan 31 2026, 6:05 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T12714: `differential.createcomment` can race automatic revision closure
T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction
Commits
rP653bc0fa019f: Read lock all transaction edits
Summary

Ref T13054. Fixes T12714. Applies read locks to all transactions instead of only a very select subset (chat messages in Conpherence).

Test Plan

See <T13054#235650> for discussion and testing.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2018, 2:05 AM
Harbormaster failed remote builds in B19494: Diff 45691!Feb 11 2018, 2:06 AM
epriestley mentioned this in T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.Feb 11 2018, 4:00 AM
epriestley updated this revision to Diff 45692.Feb 11 2018, 4:02 AM
  • Save password hashes after upgrade (see T13054#235670).
  • Unlock and kill transactions more consistently.
Harbormaster completed remote builds in B19495: Diff 45692.Feb 11 2018, 4:02 AM
Harbormaster completed remote builds in B19495: Diff 45692.
epriestley requested review of this revision.Feb 11 2018, 4:03 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2018, 4:07 AM
Closed by commit rP653bc0fa019f: Read lock all transaction edits (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
engine/
4 lines
conpherence/
editor/
18 lines
transactions/
editor/
162 lines

Diff 45693

View Options

src/applications/auth/engine/PhabricatorAuthPasswordEngine.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility