Differential D19051

Allow a wider range of characters in macro names, including emoji
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 10:32 PM.

Details

Reviewers: None
Maniphest Tasks: T6121: Support non-latin characters in macros
Commits: rP4fef0a612824: Allow a wider range of characters in macro names, including emoji

Summary

Fixes T6121. See PHI357.

Allow emoji and other unicode (like Chinese characters) as long as you have at least three of them.
Disallow macros with only latin symbols. These were previously allowed.

Test Plan

Created a macro for "🐶🐶🐶", then used it in a comment.

Diff Detail

Repository

rP Phabricator

Branch

macro2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19472
Build 26343: Run Core Tests
Build 26342: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 10:32 PM

Harbormaster completed remote builds in B19472: Diff 45675.Feb 9 2018, 10:34 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 10:34 PM

epriestley requested review of this revision.

Closed by commit rP4fef0a612824: Allow a wider range of characters in macro names, including emoji (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

macro/

markup/

PhabricatorImageMacroRemarkupRule.php

2 lines

xaction/

PhabricatorMacroNameTransaction.php

47 lines

__tests__/

PhabricatorMacroTestCase.php

46 lines

Diff 45675

View Options

src/__phutil_library_map__.php

View Options

src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php

View Options

src/applications/macro/xaction/PhabricatorMacroNameTransaction.php

View Options

src/applications/macro/xaction/tests/PhabricatorMacroTestCase.php

Allow a wider range of characters in macro names, including emojiClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45675

src/__phutil_library_map__.php

src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php

src/applications/macro/xaction/PhabricatorMacroNameTransaction.php

src/applications/macro/xaction/__tests__/PhabricatorMacroTestCase.php

Allow a wider range of characters in macro names, including emoji
ClosedPublic
Actions

Revision Contents
Changeset List

src/applications/macro/xaction/tests/PhabricatorMacroTestCase.php