Page MenuHomePhabricator
Differential D19051

Allow a wider range of characters in macro names, including emoji
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 3:28 AM
Unknown Object (File)
Mon, Dec 16, 1:47 PM
Unknown Object (File)
Sun, Dec 15, 1:40 AM
Unknown Object (File)
Mon, Dec 2, 3:36 PM
Unknown Object (File)
Fri, Nov 29, 10:57 AM
Unknown Object (File)
Fri, Nov 29, 6:57 AM
Unknown Object (File)
Thu, Nov 28, 9:42 PM
Unknown Object (File)
Wed, Nov 27, 2:48 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T6121: Support non-latin characters in macros
Commits
rP4fef0a612824: Allow a wider range of characters in macro names, including emoji
Summary

Fixes T6121. See PHI357.

  • Allow emoji and other unicode (like Chinese characters) as long as you have at least three of them.
  • Disallow macros with only latin symbols. These were previously allowed.
Test Plan

Created a macro for "🐶🐶🐶", then used it in a comment.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 9 2018, 10:32 PM
Harbormaster completed remote builds in B19472: Diff 45675.Feb 9 2018, 10:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 10:34 PM
epriestley requested review of this revision.
Closed by commit rP4fef0a612824: Allow a wider range of characters in macro names, including emoji (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
macro/
markup/
2 lines
xaction/
47 lines
__tests__/
46 lines

Diff 45676

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/macro/markup/PhabricatorImageMacroRemarkupRule.php

Loading...
View Options

src/applications/macro/xaction/PhabricatorMacroNameTransaction.php

Loading...
View Options

src/applications/macro/xaction/__tests__/PhabricatorMacroTestCase.php

Loading...
Phabricator · Built by Phacility