Page MenuHomePhabricator
Differential D19041

Add inline comment counts to the filetree view
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 1:01 AM.
Tags
None
Referenced Files
F13285955: D19041.diff
Tue, Jun 4, 5:03 AM
F13268780: D19041.diff
Wed, May 29, 5:22 AM
F13252216: D19041.diff
Sat, May 25, 1:11 AM
F13249673: D19041.diff
Fri, May 24, 10:29 AM
F13236531: D19041.id45655.diff
Tue, May 21, 10:00 AM
F13227847: D19041.id45655.diff
Mon, May 20, 5:15 AM
F13208356: D19041.diff
Thu, May 16, 2:30 PM
F13204736: D19041.diff
Wed, May 15, 12:53 AM
View All 97 Files
Subscribers
None

Details

Reviewers
None
Commits
rP261a4a0e51fd: Add inline comment counts to the filetree view
Summary

See PHI356. Adds inline comment and done counts to the filetree. Also makes the filetree wider by default.

Test Plan

Fiddled with filetrees in different browsers on different revisions. Added inlines, marked them done/undone.

Diff Detail

Repository
rP Phabricator
Branch
filetree2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19449
Build 26309: Run Core Tests
Build 26308: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 9 2018, 1:01 AM
Harbormaster completed remote builds in B19449: Diff 45654.Feb 9 2018, 1:02 AM
epriestley requested review of this revision.Feb 9 2018, 1:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 1:15 AM
Closed by commit rP261a4a0e51fd: Add inline comment counts to the filetree view (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
78 lines
src/
applications/
differential/
view/
1 line
12 lines
webroot/
rsrc/
css/
aphront/
6 lines
layout/
33 lines
js/
application/
diff/
74 lines
5 lines
core/
4 lines

Diff 45654

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-filetree-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...
Phabricator · Built by Phacility