Page MenuHomePhabricator
Differential D19041

Add inline comment counts to the filetree view
ClosedPublic
Actions

Authored by epriestley on Feb 9 2018, 1:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 31, 11:02 AM
Unknown Object (File)
Wed, Jan 29, 1:39 PM
Unknown Object (File)
Sat, Jan 25, 7:24 AM
Unknown Object (File)
Fri, Jan 24, 8:52 PM
Unknown Object (File)
Fri, Jan 24, 3:11 AM
Unknown Object (File)
Wed, Jan 22, 11:53 PM
Unknown Object (File)
Dec 30 2024, 8:08 PM
Unknown Object (File)
Dec 30 2024, 8:08 PM
View All Files
Subscribers
None

Details

Reviewers
None
Commits
rP261a4a0e51fd: Add inline comment counts to the filetree view
Summary

See PHI356. Adds inline comment and done counts to the filetree. Also makes the filetree wider by default.

Test Plan

Fiddled with filetrees in different browsers on different revisions. Added inlines, marked them done/undone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 9 2018, 1:01 AM
Harbormaster completed remote builds in B19449: Diff 45654.Feb 9 2018, 1:02 AM
epriestley requested review of this revision.Feb 9 2018, 1:02 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 9 2018, 1:15 AM
Closed by commit rP261a4a0e51fd: Add inline comment counts to the filetree view (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
78 lines
src/
applications/
differential/
view/
1 line
12 lines
webroot/
rsrc/
css/
aphront/
6 lines
layout/
33 lines
js/
application/
diff/
74 lines
5 lines
core/
4 lines

Diff 45655

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetDetailView.php

Loading...
View Options

src/applications/differential/view/DifferentialChangesetFileTreeSideNavBuilder.php

Loading...
View Options

webroot/rsrc/css/aphront/phabricator-nav-view.css

Loading...
View Options

webroot/rsrc/css/layout/phabricator-filetree-view.css

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangeset.js

Loading...
View Options

webroot/rsrc/js/application/diff/DiffChangesetList.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-nav.js

Loading...
Phabricator · Built by Phacility