Paths

Table of Contentst

Differential D19036

Remove completely pointless load of every repository when viewing a repository URI
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 8:43 PM.

Tags

None

Referenced Files

	F15420441: D19036.id45643.diff
	Fri, Mar 21, 2:03 PM

	F15396036: D19036.id45643.diff
	Sun, Mar 16, 11:22 AM

	F15394174: D19036.id.diff
	Sat, Mar 15, 11:21 PM

	F15394170: D19036.diff
	Sat, Mar 15, 11:21 PM

	F15391933: D19036.diff
	Sat, Mar 15, 12:25 PM

	F15378656: D19036.diff
	Thu, Mar 13, 4:01 PM

	Unknown Object (File)
	Feb 17 2025, 6:15 PM

	Unknown Object (File)
	Feb 13 2025, 2:55 AM

View All Files

Subscribers

jmeador

Details

Reviewers: None
Commits: rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository…

Summary

See D18176. This query has no effect (other than wasting resources) and the result is unused.

$repository already has the URI loaded because we load them unconditionally during request initialization.

Test Plan

Viewed repository URIs.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 8 2018, 8:43 PM

epriestley mentioned this in D18176: Correct a datasource issue when viewing repository URIs in "Manage Repository".Feb 8 2018, 8:43 PM

Harbormaster completed remote builds in B19438: Diff 45643.Feb 8 2018, 8:44 PM

epriestley requested review of this revision.Feb 8 2018, 8:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 8:47 PM

Closed by commit rPd1e273daf62f: Remove completely pointless load of every repository when viewing a repository… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

(T6928 could have caught this statically.)

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionRepositoryURIViewController.php

6 lines

Diff 45644

View Options

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Remove completely pointless load of every repository when viewing a repository URIClosedPublicActions