Differential D19034

Remove `addHighlight()` action view methods
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 8:13 PM.

Tags

None

Referenced Files

	F20595776: D19034.diff
	Sat, Jun 20, 12:44 AM

	Unknown Object (File)
	Wed, Jun 3, 10:55 AM

	Unknown Object (File)
	Apr 15 2026, 6:53 AM

	Unknown Object (File)
	Apr 1 2026, 6:02 PM

	Unknown Object (File)
	Mar 29 2026, 5:12 AM

	Unknown Object (File)
	Feb 26 2026, 7:17 AM

	Unknown Object (File)
	Feb 1 2026, 1:15 AM

	Unknown Object (File)
	Dec 24 2025, 7:14 AM

View All Files

Subscribers

None

Details

Reviewers: None
Commits: rP705ff8d33de0: Remove `addHighlight()` action view methods

Summary

These didn't actually get used by D19033.

Test Plan

Grep.

Diff Detail

Repository

rP Phabricator

Branch

highlight1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19435
Build 26287: Run Core Tests
Build 26286: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2018, 8:13 PM

Harbormaster completed remote builds in B19435: Diff 45640.Feb 8 2018, 8:14 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 8:14 PM

epriestley requested review of this revision.

Closed by commit rP705ff8d33de0: Remove `addHighlight()` action view methods (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

layout/

PhabricatorActionView.php

10 lines

Diff 45640

View Options

src/view/layout/PhabricatorActionView.php

Remove `addHighlight()` action view methodsClosedPublicActions