Page MenuHomePhabricator
Differential D19027

Improve correctness of email address escaping in Mailgun/Postmark
ClosedPublic
Actions

Authored by epriestley on Feb 8 2018, 5:00 PM.
Tags
None
Referenced Files
F18755908: D19027.id45625.diff
Sun, Oct 5, 8:13 AM
F18755154: D19027.diff
Sun, Oct 5, 4:03 AM
F18566564: D19027.id.diff
Tue, Sep 9, 2:43 PM
F18502086: D19027.diff
Sep 4 2025, 10:11 PM
F18269715: D19027.id45624.diff
Aug 22 2025, 2:55 PM
F18215665: D19027.id.diff
Aug 19 2025, 7:00 AM
F17742960: D19027.diff
Jul 21 2025, 1:19 PM
F17713247: D19027.id45624.diff
Jul 17 2025, 1:00 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13053: Plans: Mail Tags and Failover
Commits
rP942b17a98088: Improve correctness of email address escaping in Mailgun/Postmark
Summary

Ref T13053. Uses the changes in D19026 to escape mail addresses. Those rules may not be right yet, but they're at least all in one place, have test coverage, and aren't obviously incorrect.

Test Plan

Will vet this more extensively when re-testing all mailers.

Diff Detail

Repository
rP Phabricator
Branch
mail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19419
Build 26262: Run Core Tests
Build 26261: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 8 2018, 5:00 PM
Harbormaster completed remote builds in B19419: Diff 45624.Feb 8 2018, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2018, 5:01 PM
epriestley requested review of this revision.
Closed by commit rP942b17a98088: Improve correctness of email address escaping in Mailgun/Postmark (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45624

View Options

src/applications/metamta/adapter/PhabricatorMailImplementationAdapter.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php

Loading...
Phabricator · Built by Phacility