Page MenuHomePhabricator

Migrate VCS passwords to new shared password infrastructure
ClosedPublic

Authored by epriestley on Jan 21 2018, 4:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 5:13 PM
Unknown Object (File)
Wed, Feb 28, 1:54 PM
Unknown Object (File)
Wed, Feb 28, 1:39 PM
Unknown Object (File)
Feb 15 2024, 3:30 AM
Unknown Object (File)
Jan 8 2024, 4:35 PM
Unknown Object (File)
Jan 7 2024, 1:01 PM
Unknown Object (File)
Dec 29 2023, 10:03 AM
Unknown Object (File)
Dec 26 2023, 7:33 PM
Subscribers
None

Details

Summary

Ref T13043. Migrate VCS passwords away from their dedicated table to new the new shared infrastructure.

Future changes will migrate account passwords and remove the old table.

Test Plan
  • Ran migrations.
    • Cloned with the same password that was configured before the migrations (worked).
    • Cloned with a different, invalid password (failed).
  • Changed password.
    • Cloned with old password (failed).
    • Cloned with new password (worked).
  • Deleted password in web UI.
    • Cloned with old password (failed).
  • Set password to the same password as it currently is set to (worked, no "unique" collision).
  • Set password to account password. This (incorrectly) works for now until account passwords migrate, since the uniqueness check can't see them yet.
  • Set password to a new unique password.
    • Cloned (worked).
    • Revoked the password with bin/auth revoke.
    • Verified web UI shows "no password set".
    • Verified that pull no longer works.
    • Verified that I can no longer select the revoked password.
  • Verified that accounts do not interact:
    • Tried to set account B to account A's password (worked).
    • Tried to set account B to a password revoked on account A (worked).
  • Spot checked the password and passwordtransaction tables for saniity.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 23 2018, 2:53 AM