Page MenuHomePhabricator

Make bulk edit <select /> fields a little more natrual and set options for subtype transactions
ClosedPublic

Authored by epriestley on Jan 19 2018, 2:57 PM.
Tags
None
Referenced Files
F13295089: D18878.id45289.diff
Wed, Jun 5, 10:14 PM
F13287267: D18878.diff
Tue, Jun 4, 8:33 AM
F13274538: D18878.diff
Fri, May 31, 3:49 AM
F13260602: D18878.diff
Mon, May 27, 12:08 AM
F13242934: D18878.diff
Thu, May 23, 3:13 AM
F13221280: D18878.diff
Sun, May 19, 2:25 AM
F13206305: D18878.diff
Wed, May 15, 6:52 AM
F13203700: D18878.diff
Wed, May 15, 12:00 AM
Subscribers
None

Details

Summary

Ref T13025. This is some minor technical stuff: make the "select" bulk edit type a little more consistent with other types by passing data down instead of having it reach up the stack. This simplifies the implementation of a custom field "select" in a future change.

Also, provide an option list to the "select" edit field for object subtypes. This is only accessible via Conduit so it currently never actually renders anything in the UI, but with the bulk edit stuff we get some initialization order issues if we don't set anything. This will also make any future changes which expose subtypes more broadly more straightforward.

Test Plan
  • Bulk edited "select" fields, like "Status" and "Priority".
  • No more fatal when trying to getOptions() internally on the subtype field.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable