Page MenuHomePhabricator

Fix a bug with setting custom PHID list field values via Conduit and prepare for bulk edits
ClosedPublic

Authored by epriestley on Jan 19 2018, 2:23 PM.
Tags
None
Referenced Files
F13304340: D18876.diff
Sat, Jun 8, 9:00 AM
F13287373: D18876.diff
Tue, Jun 4, 8:41 AM
F13274688: D18876.diff
Fri, May 31, 3:59 AM
F13247694: D18876.diff
Thu, May 23, 9:44 PM
F13234783: D18876.diff
Tue, May 21, 3:45 AM
F13212749: D18876.diff
Fri, May 17, 7:01 AM
F13206307: D18876.diff
Wed, May 15, 6:52 AM
F13197479: D18876.diff
May 13 2024, 12:13 AM
Subscribers
None

Details

Summary

Ref T13025. Custom field transactions work somewhat unusually: the values sometimes need to be encoded. We currently do not apply this encoding correctly via Conduit.

For example, setting some custom PHID field to ["PHID-X-Y"] fails with a bunch of JSON errors.

Add an extra hook callback so that EditTypes can apply processing to transaction values, then apply the correct CustomField processing.

This only affects Conduit. In a future diff, this also allows bulk edit of custom fields to work correctly.

Test Plan

Added a custom field to Maniphest with a list of projects. Used Conduit to bulk edit it (which now works, but did not before). Used the web UI to bulk edit it.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable