Page MenuHomePhabricator

Add trailing tabs when generating synthetic Git diffs for files with spaces

Authored by epriestley on Jan 16 2018, 4:26 PM.
Referenced Files
Unknown Object (File)
Fri, Jul 29, 11:14 PM
Unknown Object (File)
Wed, Jul 27, 2:14 PM
Unknown Object (File)
Wed, Jul 13, 7:19 AM
Unknown Object (File)
Jul 7 2022, 12:08 AM
Unknown Object (File)
Jul 4 2022, 6:34 PM
Unknown Object (File)
Jul 2 2022, 12:45 PM
Unknown Object (File)
Jun 26 2022, 5:32 PM
Unknown Object (File)
Jun 19 2022, 12:28 AM



Fixes T8768. See PHI294. See that task for more details.

Git, Mercurial, diff, and patch have conspired to make things weird. To correctly handle files with spaces in the way everything else does and expects, we need to emit semantic trailing whitespace literals.

Test Plan
  • Created a file with spaces in it in a Mercurial repositroy, committed it, diffed it into a revision.
  • Used arc patch to apply the change to a clean copy of the repository.
  • Before patch: Mercurial incorrectly creates a file named X, not a file named X Y.txt.
  • After patch: arc patch commit is identical to genuine commit.
  • Also added test coverage. The other general behaviors here are fairly well covered already.

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable