Page MenuHomePhabricator

Don't notify without notifiable attendees
ClosedPublic

Authored by 0 on Dec 21 2017, 8:44 PM.
Tags
None
Referenced Files
F13096709: D18835.diff
Thu, Apr 25, 6:28 PM
Unknown Object (File)
Fri, Apr 19, 7:03 PM
Unknown Object (File)
Mon, Apr 8, 5:53 AM
Unknown Object (File)
Tue, Apr 2, 4:42 PM
Unknown Object (File)
Thu, Mar 28, 9:31 AM
Unknown Object (File)
Mar 14 2024, 7:13 AM
Unknown Object (File)
Mar 4 2024, 9:02 PM
Unknown Object (File)
Feb 19 2024, 8:52 AM
Subscribers

Details

Summary

Events with no attendees (e.g. fresh instances of recurring events) would trigger an exception when sending notifications, because $attendee_map would still get populated.

Test Plan

Declined event, restarted daemons. Did not see exception. Accepted event, restarted daemons. Saw "[Calendar] [Reminder]" email.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable