Page MenuHomePhabricator
Differential D18813

Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens
ClosedPublic
Actions

Authored by lpriestley on Nov 30 2017, 9:56 PM.
Tags
None
Referenced Files
F14077269: D18813.diff
Thu, Nov 21, 10:16 PM
Unknown Object (File)
Fri, Nov 8, 9:34 AM
Unknown Object (File)
Oct 9 2024, 8:20 AM
Unknown Object (File)
Sep 6 2024, 1:35 AM
Unknown Object (File)
Sep 6 2024, 1:35 AM
Unknown Object (File)
Sep 6 2024, 1:35 AM
Unknown Object (File)
Sep 2 2024, 6:10 AM
Unknown Object (File)
Aug 31 2024, 11:08 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T13019: Build Status is integrated into Diffusion in a hacky way
Commits
rP42034e6739eb: Property list view on Diffusion commits should show build status but not…
Summary

Ref T13019, adds build status back to Diffusion commits

Test Plan

Open a Diffusion commit that has a build status, property list view should show the build status, but not Subscriptions, Projects, or Tokens.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley created this revision.Nov 30 2017, 9:56 PM
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2017, 9:56 PM
Harbormaster completed remote builds in B18909: Diff 45136.Nov 30 2017, 9:57 PM
lpriestley requested review of this revision.Nov 30 2017, 9:57 PM
epriestley accepted this revision.Nov 30 2017, 10:04 PM

(This should maybe just Ref rather than Fixes on T13019 and leave it open for some theoretical day long from now when we circle back and fix this properly.)

This revision is now accepted and ready to land.Nov 30 2017, 10:04 PM
Herald added a subscriber: Korvin. · View Herald TranscriptNov 30 2017, 10:04 PM
lpriestley edited the summary of this revision. (Show Details)Nov 30 2017, 10:48 PM
Closed by commit rP42034e6739eb: Property list view on Diffusion commits should show build status but not… (authored by lpriestley). · Explain WhyDec 1 2017, 6:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
3 lines
project/
events/
8 lines
subscriptions/
events/
8 lines
tokens/
event/
8 lines

Diff 45144

View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...
View Options

src/applications/tokens/event/PhabricatorTokenUIEventListener.php

Loading...
Phabricator · Built by Phacility