Page MenuHomePhabricator

Fix an error with Remarkup when a header-indicator row has more cells than the one above it
ClosedPublic

Authored by epriestley on Oct 31 2017, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 1 2025, 6:39 AM
Unknown Object (File)
Feb 26 2025, 8:04 AM
Unknown Object (File)
Feb 9 2025, 4:49 AM
Unknown Object (File)
Feb 9 2025, 4:49 AM
Unknown Object (File)
Feb 9 2025, 4:49 AM
Unknown Object (File)
Feb 7 2025, 10:18 AM
Unknown Object (File)
Jan 24 2025, 10:47 PM
Unknown Object (File)
Jan 24 2025, 10:47 PM
Subscribers
None

Details

Summary

From fishing through error logs in PHI184. When row 1 has less cells than row 2, and row 2 has a |--| section (indicating that the cell above should be a table header), we try to convert an invalid cell into a table header. PHP obliges and creates this cell, but it doesn't have 'content', which produces this error:

ERROR 8: Undefined index: content at [/core/lib/libphutil/src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockRule.php:160]

Test Plan

Added a failing (well, complaining) test; made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable