Page MenuHomePhabricator

Fix an error with Remarkup when a header-indicator row has more cells than the one above it
ClosedPublic

Authored by epriestley on Oct 31 2017, 8:22 PM.
Tags
None
Referenced Files
F14008903: D18751.id45007.diff
Wed, Oct 30, 7:44 AM
F13961318: D18751.diff
Tue, Oct 15, 4:25 AM
F13960543: D18751.id45011.diff
Mon, Oct 14, 11:55 PM
Unknown Object (File)
Fri, Oct 11, 4:39 AM
Unknown Object (File)
Sep 6 2024, 1:25 AM
Unknown Object (File)
Sep 4 2024, 9:33 PM
Unknown Object (File)
Aug 25 2024, 5:25 AM
Unknown Object (File)
Aug 20 2024, 12:22 PM
Subscribers
None

Details

Summary

From fishing through error logs in PHI184. When row 1 has less cells than row 2, and row 2 has a |--| section (indicating that the cell above should be a table header), we try to convert an invalid cell into a table header. PHP obliges and creates this cell, but it doesn't have 'content', which produces this error:

ERROR 8: Undefined index: content at [/core/lib/libphutil/src/markup/engine/remarkup/blockrule/PhutilRemarkupBlockRule.php:160]

Test Plan

Added a failing (well, complaining) test; made it pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable