Page MenuHomePhabricator

Clean up Differential draft mail behaviors
ClosedPublic

Authored by epriestley on Oct 31 2017, 6:53 PM.

Details

Summary

Ref T2543. Fixes two relatively minor things:

  • When builds finish in Harbormaster, send mail "From" the author.
  • Set the firstBroadcast flag so that initial mail picks up earlier history (notably, the "reviewers" line).

For now, I'm not setting firstBroadcast on explicit "Request Review" (but maybe we should), and not trying to deal with weird cases where you leave a bunch of comments on a draft. Those might be fine as-is or may get tweaked later.

Test Plan

Created a revision with Harbormaster builds, ran builds, saw initial email come "From" the right user with more metadata.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Oct 31 2017, 6:53 PM
epriestley requested review of this revision.Oct 31 2017, 6:54 PM
epriestley updated this revision to Diff 45000.Oct 31 2017, 6:56 PM
  • Actual change, I raced git in another window.
epriestley updated this revision to Diff 45001.Oct 31 2017, 6:57 PM
  • Too many windows.
amckinley accepted this revision.Oct 31 2017, 7:40 PM
This revision is now accepted and ready to land.Oct 31 2017, 7:40 PM
This revision was automatically updated to reflect the committed changes.