Page MenuHomePhabricator

Parameterize the common ngrams threshold
ClosedPublic

Authored by epriestley on Oct 17 2017, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:44 AM
Unknown Object (File)
Tue, Dec 17, 1:37 PM
Unknown Object (File)
Sat, Dec 14, 4:56 PM
Unknown Object (File)
Dec 7 2024, 11:56 PM
Unknown Object (File)
Dec 3 2024, 11:23 PM
Unknown Object (File)
Dec 3 2024, 4:10 PM
Unknown Object (File)
Nov 30 2024, 10:23 AM
Unknown Object (File)
Nov 26 2024, 6:10 PM
Subscribers
None

Details

Summary

Ref T13000. Since other changes have generally made the ngrams table manageable, I'm not planning to enable common ngrams by default at this time.

Instead, make the threshold configurable with "--threshold" so we can guide installs through tuning this if they want (e.g. PHI110), and tune hosted instances.

(This might eventually become automatic, but just smoothing this bit off for now feels reasonable to me.)

Test Plan

Ran with --reset, and with various invalid and valid --threshold arguments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/applications/search/management/PhabricatorSearchManagementNgramsWorkflow.php
23–24

I see we validate this below, but maybe add a note in the help text indicating that we expect a float between 0.0 and 1.0?

This revision is now accepted and ready to land.Oct 17 2017, 9:08 PM
This revision was automatically updated to reflect the committed changes.