Page MenuHomePhabricator

Fix a bug which prevented Conduit futures from having parallelism limited effectively
ClosedPublic

Authored by epriestley on Oct 12 2017, 7:18 PM.
Tags
None
Referenced Files
F13979809: D18704.diff
Sat, Oct 19, 6:40 AM
F13963694: D18704.id44897.diff
Tue, Oct 15, 5:20 PM
F13959622: D18704.id44901.diff
Mon, Oct 14, 8:04 PM
Unknown Object (File)
Wed, Oct 9, 7:29 PM
Unknown Object (File)
Oct 9 2024, 8:16 AM
Unknown Object (File)
Sep 12 2024, 9:44 AM
Unknown Object (File)
Sep 12 2024, 9:43 AM
Unknown Object (File)
Sep 12 2024, 9:43 AM
Subscribers
None

Details

Summary

Ref T13008. Currently, ConduitClient calls isReady() on futures before returning them.

This is very old, and wrong: it makes the future activate and start working. In the case of ConduitFutures, which wrap HTTPFutures, it causes them to make an HTTP request.

Instead, return dormant futures without calling isReady(). Then the construct used by ArcanistFileUploader and many other pieces of code will limit parallelism properly:

$iterator = id(new FutureIterator($futures))
  ->limit(4);
foreach ($iterator as $future) {
 // ...
}

Also, fix up the --trace profiler integration so we get a log when the future actually starts, not when we create it.

Test Plan

Ran arc upload --trace ... with a bunch of files, fiddling with the limit(X). Saw 4 (default) and 1 properly throttle requests. Saw 200 unthrottle requests.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable