Page MenuHomePhabricator

Add a garbage collector for common ngrams
ClosedPublic

Authored by epriestley on Oct 5 2017, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 6 2026, 7:11 PM
Unknown Object (File)
Mar 30 2026, 7:36 PM
Unknown Object (File)
Mar 21 2026, 10:59 PM
Unknown Object (File)
Mar 14 2026, 10:25 AM
Unknown Object (File)
Mar 14 2026, 7:54 AM
Unknown Object (File)
Dec 25 2025, 10:36 PM
Unknown Object (File)
Dec 9 2025, 7:45 PM
Unknown Object (File)
Nov 26 2025, 4:55 AM
Subscribers
None

Details

Summary

Ref T13000. After an ngram is marked as "common", we can delete it from the storage table.

Currently, the only way to get ngrams marked as "common" is to manually run bin/search ngrams, so this has no impact on normal installs.

Test Plan

Ran bin/garbage collect, saw it start chewing through my local Maniphest ngrams table and removing common ngrams.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Also add a little warning text to bin/search ngrams.
This revision is now accepted and ready to land.Oct 5 2017, 6:01 PM
This revision was automatically updated to reflect the committed changes.