Page MenuHomePhabricator

Add a garbage collector for common ngrams
ClosedPublic

Authored by epriestley on Oct 5 2017, 12:27 AM.
Tags
None
Referenced Files
F12833021: D18687.diff
Thu, Mar 28, 1:46 PM
Unknown Object (File)
Tue, Mar 5, 9:55 AM
Unknown Object (File)
Feb 11 2024, 12:59 PM
Unknown Object (File)
Feb 8 2024, 1:44 PM
Unknown Object (File)
Feb 4 2024, 7:02 PM
Unknown Object (File)
Feb 3 2024, 5:02 PM
Unknown Object (File)
Dec 27 2023, 12:16 PM
Unknown Object (File)
Dec 27 2023, 12:15 PM
Subscribers
None

Details

Summary

Ref T13000. After an ngram is marked as "common", we can delete it from the storage table.

Currently, the only way to get ngrams marked as "common" is to manually run bin/search ngrams, so this has no impact on normal installs.

Test Plan

Ran bin/garbage collect, saw it start chewing through my local Maniphest ngrams table and removing common ngrams.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Also add a little warning text to bin/search ngrams.
This revision is now accepted and ready to land.Oct 5 2017, 6:01 PM
This revision was automatically updated to reflect the committed changes.