Differential D18676
Add a "/source/..." URI for Diffusion commits which redirects Authored by epriestley on Oct 3 2017, 7:52 PM. Tags None Referenced Files
Subscribers None
Details See PHI112. The install presumably wants to generate links to Diffusion commits from an external tool, but only knows the short name of the repository. Provide a /source/phabricator/commit/abcdef908273 URI which redirects to the canonical URI for the commit.
Diff Detail
Event TimelineComment Actions Just out of curiosity, what happens if a commit identifier collides with more than one commit hash? Comment Actions Hmm.. bad stuff, but pre-existing bad stuff: $ git log --oneline --format=%H | cut -c1-6 | sort | uniq -c | sort -n ... 2 bd3c23 Yields this: https://secure.phabricator.com/rPbd3c23 ...which fatals, probably on executeOne().
Better behavior would be to execute(), then special case for multiple results. |