Page MenuHomePhabricator

Allow the fulltext index to select only transactions with comments
ClosedPublic

Authored by epriestley on Sep 28 2017, 7:51 PM.
Tags
None
Referenced Files
F14402806: D18660.id44800.diff
Mon, Dec 23, 1:05 AM
Unknown Object (File)
Fri, Dec 20, 1:57 PM
Unknown Object (File)
Sat, Dec 14, 5:30 PM
Unknown Object (File)
Thu, Dec 5, 11:11 AM
Unknown Object (File)
Fri, Nov 29, 5:57 PM
Unknown Object (File)
Fri, Nov 29, 1:22 AM
Unknown Object (File)
Tue, Nov 26, 1:03 PM
Unknown Object (File)
Sun, Nov 24, 9:29 PM
Subscribers
None

Details

Summary

Ref T12997. Although we can't query by transaction type (since we can't easily enumerate all possible types which may have comments -- inline types may also have comments), we can just check if there's a comment row or not.

This reduces the amount of garbage we need to load to rebuild indexes for unusual objects with hundreds and hundreds of mentions.

Test Plan
  • Used batch editor to mention a task 700 times.
  • Indexed it before and after this change, saw index time drop from 1600ms160ms.
  • Made some new comments on it, verified that they still indexed/queried properly.
  • Browsed around, made normal transactions, made inline comments.
  • Added a unique word to an inline comment, indexed revision, searched for word, found revision.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 28 2017, 7:54 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in Unknown Object (Maniphest Task).Sep 28 2017, 7:57 PM