Page MenuHomePhabricator

When we purge the request cache, also force PHP to collect cycles
ClosedPublic

Authored by epriestley on Sep 28 2017, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 7, 1:11 PM
Unknown Object (File)
Mar 20 2024, 2:07 AM
Unknown Object (File)
Mar 15 2024, 7:02 AM
Unknown Object (File)
Feb 26 2024, 4:30 PM
Unknown Object (File)
Feb 26 2024, 1:57 PM
Unknown Object (File)
Jan 17 2024, 9:13 PM
Unknown Object (File)
Dec 25 2023, 1:57 PM
Unknown Object (File)
Dec 6 2023, 1:01 AM
Subscribers
None

Details

Summary

Ref T12997. See that task for more details. Briefly, an unusual dataset (where commits are mentioned hundreds of times by other commits) is causing some weird memory behavior in the daemons.

Forcing PHP to GC cycles explicitly after each task completes seems to help with this, by cleaning up some of the memory between tasks. A more thorough fix might be to untangle the $xactions structure, but that's significantly more involved.

Test Plan
  • Did this locally in a controlled environment, saw an immediate collection of a 500MB $xactions cycle.
  • Put a similar change in production, memory usage seemed less to improve. It's hard to tell for sure that this does anything, but it shouldn't hurt.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable