Page MenuHomePhabricator

Remove "arc lint --only-changed"
ClosedPublic

Authored by epriestley on Sep 25 2017, 6:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 17, 2:10 PM
Unknown Object (File)
Tue, Sep 13, 2:22 AM
Unknown Object (File)
Sun, Sep 11, 2:28 AM
Unknown Object (File)
Wed, Sep 7, 6:11 AM
Unknown Object (File)
Sun, Sep 4, 5:49 PM
Unknown Object (File)
Aug 22 2022, 7:52 AM
Unknown Object (File)
Aug 21 2022, 3:36 AM
Unknown Object (File)
Aug 19 2022, 12:06 AM
Subscribers
None

Details

Summary

Ref T12996. See also T9749. This option is the opposite of --lintall, and means "don't show warnings on changed lines".

However, it's confusing (and I think no one uses it), and we can reasonably infer what you mean if you give us --rev. Simplify this logic a bit and choose the "all / only changed" behavior based on the only sensible thing we can reasonably do given the flags.

As with all the other cruft here, I'm pretty sure this came from FB.

Test Plan

Grepped for only-changed, lintAll, created this revision.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley added inline comments.
src/workflow/ArcanistLintWorkflow.php
172–176

I personally prefer the Boy Scout Motto style of lint enforcement, but this is a reasonable default.

This revision is now accepted and ready to land.Sep 25 2017, 7:56 PM
This revision was automatically updated to reflect the committed changes.
src/workflow/ArcanistLintWorkflow.php
209

This condition got flipped and I didn't catch it in my initial poking, but D18651 has a fix for it.