Page MenuHomePhabricator

Add a "Draft" state for revisions, and action bucket support
ClosedPublic

Authored by epriestley on Sep 18 2017, 7:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 29, 8:56 AM
Unknown Object (File)
Wed, May 28, 12:22 PM
Unknown Object (File)
Wed, May 7, 2:45 AM
Unknown Object (File)
Apr 26 2025, 8:48 AM
Unknown Object (File)
Apr 25 2025, 8:06 AM
Unknown Object (File)
Mar 30 2025, 6:51 AM
Unknown Object (File)
Mar 27 2025, 11:15 PM
Unknown Object (File)
Mar 25 2025, 10:29 AM
Subscribers
None

Details

Summary

Ref T2543. There's no way to put revisions into this state yet, but start adding support for when there is.

Adds the status constant, plus support for bucketing them.

Test Plan
  • Manually put a revision in "Draft" state by updating the database directly.
  • Verified my drafts showed up in a "Drafts" section on the bucket view.
  • Verified others' drafts did not appear on the action bucket view.
  • Viewed revisions, queried for "Draft" revisions, etc (stuff we get for free).

Screen Shot 2017-09-18 at 12.56.40 PM.png (132×274 px, 14 KB)

Screen Shot 2017-09-18 at 12.54.05 PM.png (235×284 px, 21 KB)

Screen Shot 2017-09-18 at 12.54.00 PM.png (236×396 px, 20 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable